docs(readme): remove vaadin directory #191
Conversation
WalkthroughThe pull request removes an XML code block in the README file that defined a Maven repository for Vaadin addons. The block containing the Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
README.md (3)
1-4: Review Badge References to Vaadin Directory
The badges on lines 1–4 still reference the Vaadin Directory. Since the add-on is now released through Maven Central (per the PR description), please double-check whether these badges need updating or removal to avoid confusion.
22-25: Update Download Release Section
On line 24, the text still mentions that official releases are available at the Vaadin Directory. With the move to Maven Central, consider updating this section so it reflects the current distribution channel.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
24-24: Bare URL used
null(MD034, no-bare-urls)
1-94: Overall Documentation Consistency
The changes remove the redundant Maven repository block, which is a positive update given the shift to Maven Central. However, there remain several references to “Vaadin Directory” (e.g., badges on lines 1–4 and the download release text on line 24). Please confirm if these should be updated to reflect the new distribution strategy to maintain consistency in the documentation.🧰 Tools
🪛 LanguageTool
[uncategorized] ~12-~12: You might be missing the article “the” here.
Context: ...nColGrid is built upon the same idea of TwinColSelect component, but using grids instead of s...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~13-~13: A determiner appears to be missing. Consider inserting it.
Context: ...nent that shows two grids side by side. Left grid contains unselected items and the ...(AI_EN_LECTOR_MISSING_DETERMINER)
[uncategorized] ~13-~13: Possible missing comma found.
Context: ... by side. Left grid contains unselected items and the right grid the selected items.
...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~15-~15: Possible missing article found.
Context: ...t list and clicking on the "<" button.
Component also supports drag and drop between gri...(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~16-~16: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...king on the "<" button.
Component also supports drag and drop between grids.Onli...
(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
[uncategorized] ~38-~38: Possible missing comma found.
Context: ...on>
For SNAPSHOT versions see [here](https://maven.flowingcode.co... (AI_HYDRA_LEO_MISSING_COMMA) --- [uncategorized] ~74-~74: You might be missing the article “the” here. Context: ...r functionality carefully. Only include minimum amount of code needed to fix the issue.... (AI_EN_LECTOR_MISSING_DETERMINER_THE) --- [style] ~74-~74: Consider using a different verb for a more formal wording. Context: ...nclude minimum amount of code needed to fix the issue. - For commit message, use [... (FIX_RESOLVE) --- [uncategorized] ~81-~81: You might be missing the article “the” here. Context: ...hor This add-on is distributed under Apache License 2.0. For license terms, see LIC... (AI_EN_LECTOR_MISSING_DETERMINER_THE) --- [style] ~87-~87: Consider a shorter alternative to avoid wordiness. Context: ...on, the add-on might need to be allowed in order to display correctly. To do so, just a... (IN_ORDER_TO_PREMIUM) </details> <details> <summary>🪛 markdownlint-cli2 (0.17.2)</summary> 20-20: Bare URL used null (MD034, no-bare-urls) --- 24-24: Bare URL used null (MD034, no-bare-urls) --- 41-41: Fenced code blocks should have a language specified null (MD040, fenced-code-language) --- 47-47: Bare URL used null (MD034, no-bare-urls) </details> </details> </blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 1cb67276a3ec4d9a0e76bb01acce8f15d18d4899 and f5afca0c10bc8c00f52f40d718b00358befa24e3. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `README.md` (1 hunks) </details> <details> <summary>🔇 Additional comments (2)</summary><blockquote> <details> <summary>README.md (2)</summary> `29-36`: **Repository Configuration Cleanup Confirmed** The XML code block between lines 29–36 now only shows the dependency snippet without the extra Maven repository configuration. This aligns with the change noted in the PR (removing the Vaadin repository block). Ensure that any additional instructions regarding repository configuration (if needed) are documented elsewhere. --- `93-94`: **Spring Scanning Configuration Clarity** Line 93 now provides a link and guidance on Spring scanning configuration. Verify that the link is up to date and that this section clearly explains the configuration needed for projects using Spring. </details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Starting with 2.9.3, this add-on is released through Maven Central (see https://mvnrepository.com/artifact/com.flowingcode.vaadin.addons/twincolgrid)
Summary by CodeRabbit